[COMPASS-6801] Persist OIDC state across sessions as a secret Created: 09/May/23  Updated: 29/Oct/23  Resolved: 09/Jun/23

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: 1.38.0

Type: Task Priority: Major - P3
Reporter: Anna Henningsen Assignee: Anna Henningsen
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-5955
Story Points: 5
Documentation Changes: Not Needed
Sprint: Iteration Citipati, Iteration Dreadnoughtus

 Comments   
Comment by Githook User [ 16/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: activity-telemetry
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 14/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: 1.38-releases
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 12/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: bump-electron-23
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 12/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: latest-lodash-everywhere
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 10/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: redux-typescript-query-history-store
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 09/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801 (#4484)

Make it so that the `enableShell` toggle does not only control whether
the shell is displayed, but actually create or tear down the shell
runtime instance in according to it.

This obviously does not fix any issues on its own, but it does unblock
development on e.g. https://github.com/mongodb-js/compass/pull/4484,
and seems like a good idea in general, because it also gives users
a workaround around not just the current Electron bug, but also future
problems where having the shell process running in the background
leads to undesirable behavior in the main Compass app.

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: main
https://github.com/mongodb-js/compass/commit/5ccd18bedc3eaee0b70f2f7176cda736f8e2643e

Comment by Githook User [ 08/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801
Branch: 6801-dev
https://github.com/mongodb-js/compass/commit/1d789a2d145c34ecbf6c6fffeb8127477e166f5e

Comment by Githook User [ 06/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: feat: optionally store OIDC tokens as secrets COMPASS-6801
Branch: 6801-dev
https://github.com/mongodb-js/compass/commit/6f6c1cfd66f9c42e0d61c1e81ffe9843e2e145c2

Generated at Wed Feb 07 22:44:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.