[COMPASS-7042] Investigate changes in NODE-4936: Remove command-specific options in generic runCommand helper Created: 24/Jul/23  Updated: 29/Oct/23  Resolved: 17/Aug/23

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: No version

Type: Investigation Priority: Major - P3
Reporter: PM Bot Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: node-driver
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on NODE-4936 Remove command-specific options in ge... Closed
Documented
Related
related to MONGOSH-1478 dropIndex() not working with readPref... Closed
Epic Link: MONGOSH-1319
Documentation Changes: Not Needed
Sprint: Iteration Iguanodon

 Description   

The Node driver's Db.command() helper currently supports all options that the command helpers support.  This is problematic for two reasons:

Our `db.command()` helper should only consider options that are not command related (e.g, bson serialization options).

Acceptance Criteria

  • Remove the following options in v6

The following options are supported because of the inheritance design of our operations layer and should be removed:

  willRetryWrite?: any;
  omitReadPreference?: any;
  writeConcern?: any;
  explain?: any;
  readConcern?: any;
  collation?: any;
  maxTimeMS?: any;
  comment?: any;
  retryWrites?: any;
  dbName?: any;
  authdb?: any;
  noResponse?: any;



 Comments   
Comment by Anna Henningsen [ 17/Aug/23 ]

Should have no impact as MONGOSH-1478 is the first PR to add support for options in db.runCommand() and that is also part of t2.x, and we do not pass options internally elsewhere.

Generated at Wed Feb 07 22:45:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.