[COMPASS-7063] Apply browserCommandForOIDCAuth option to Atlas auth Created: 31/Jul/23  Updated: 29/Oct/23  Resolved: 25/Sep/23

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: 1.40.0

Type: Task Priority: Minor - P4
Reporter: Anna Henningsen Assignee: Sergey Petushkov
Resolution: Fixed Votes: 0
Labels: needs-design-input
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-6954
Story Points: 3
Documentation Changes: Not Needed
Sprint: Iteration Juravenator, Iteration Kentrosaurus

 Description   

Compare:

https://github.com/mongodb-js/compass/blob/bf580a80ee3dcdf08d35e6865e5270df0f4eb560/packages/atlas-service/src/main.ts#L98

which doesn’t have the browserCommandForOIDCAuth handling we provide in:

https://github.com/mongodb-js/compass/blob/bf580a80ee3dcdf08d35e6865e5270df0f4eb560/packages/connection-form/src/utils/oidc-handler.ts#L58



 Comments   
Comment by Githook User [ 17/Oct/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: investigate-update-preview
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 03/Oct/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: export-to-language-v6
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 26/Sep/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: feature/COMPASS-7173
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 25/Sep/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: ga-releases
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 25/Sep/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: run-search-aggregate
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 25/Sep/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: beta-releases
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Comment by Githook User [ 25/Sep/23 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(atlas-service): use server oidc browser setting for atlas login COMPASS-7063 (#4899)

  • chore(atlas-service): use server oidc browser setting for atlas login
  • chore(atlas-service): return spawned child from openBrowser for better error handling

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(preferences): remove contractions from preferences description

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • chore(compass-settings): update labels based on product input
  • chore(preferences): remove "does not apply" now that we have an explicit label for server oidc settings

More product feedback

---------

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: main
https://github.com/mongodb-js/compass/commit/ddf20a787276e2cabbc08ce1398f1fce6e0eb877

Generated at Wed Feb 07 22:45:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.