[COMPASS-7305] Don't tell electron-installer-common that the compass version is the electron version Created: 06/Oct/23 Updated: 29/Oct/23 Resolved: 06/Oct/23 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.40.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Le Roux Bodenstein | Assignee: | Le Roux Bodenstein |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
OS: |
||
| Documentation Changes: | Not Needed |
| Description |
|
electron-installer-redhat and electron-installer-debian (and probably dmg and the windows one) use electron-installer-common to determine which dependencies electron needs. It can do this for every version of electron. To do that it looks up the version of electron being used from a file called `version` and then does semver matches on it. We're writing the compass version number to that file.
So for dev releases we always get the deps required by the very first release of electron and for the current release we get ones matching 1.40.2 and so on:
We should probably fix this. Some of those deps have been removed from newer linux distros. |
| Comments |
| Comment by Githook User [ 17/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |
| Comment by Githook User [ 11/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |
| Comment by Githook User [ 10/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |
| Comment by Githook User [ 09/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |
| Comment by Githook User [ 09/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |
| Comment by Githook User [ 06/Oct/23 ] |
|
Author: {'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}Message: fix: use the electron version, not the app's version use the electron version, not the app's version |