[CSHARP-149] Remove dependency on System.Data Created: 19/Jan/11 Updated: 05/Apr/11 Resolved: 05/Apr/11 |
|
| Status: | Closed |
| Project: | C# Driver |
| Component/s: | Feature Request |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Aristarkh Zagorodnikov | Assignee: | Robert Stam |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
I would like to suggest to remove the only dependency on System.Data the current driver has – the MongoConnectionStringBuilder by either reimplementing it without inheriting from System.Data.Common.DbConnectionStringBuilder or removing it completely (there's MongoUrlBuilder already, why mess with connection strings?). I understand that this will break existing code, but still would like to ask of you to consider this change. |
| Comments |
| Comment by Robert Stam [ 05/Apr/11 ] |
|
Closed based on the decision that the dependency is not that bad. Thanks for the comments. |
| Comment by Aristarkh Zagorodnikov [ 05/Apr/11 ] |
|
I suggest that this issue should be closed, since it looks like it's not a problem after all, referencing an assembly that is in .NET BCL isn't that hard, and backwards compatibility prevails in this case. |
| Comment by Aristarkh Zagorodnikov [ 19/Jan/11 ] |
|
I don't think there's a problem on the technical side, since System.Data is always available, I was thinking that MongoConnectionStringBuilder isn't used that much – just had a (probably wrong) impression after reading the documentation, that urls are favored over connection strings and that connection strings would eventually be deprecated. |
| Comment by Robert Stam [ 19/Jan/11 ] |
|
I sympathize with your request, but we've had specific requests from people who want to manage their connection strings using .NET style support. Not sure how to accommodate them without introducing a dependency on System.Data at the same time. Is there a specific problem with having a dependency on System.Data? |
| Comment by Aristarkh Zagorodnikov [ 19/Jan/11 ] |
|
Accidentially marked as "Major" priority, should be "Minor" of course. |