[CSHARP-2760] All binary message encoders should verify the opcode when decoding a message Created: 27/Sep/19 Updated: 28/Oct/23 Resolved: 06/Feb/20 |
|
| Status: | Closed |
| Project: | C# Driver |
| Component/s: | Connectivity |
| Affects Version/s: | 2.11.0 |
| Fix Version/s: | 2.11.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Robert Stam | Assignee: | Mikalai Mazurenka (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
A few of the binary message encoders skip over the opcode while decoding a message without verifying that the opcode has the expected value. They should throw an exception if the opcode does not have the expected value. |
| Comments |
| Comment by Githook User [ 06/Feb/20 ] |
|
Author: {'username': 'MikalaiMazurenka', 'name': 'Mikalai Mazurenka', 'email': 'mikalai.mazurenka@mongodb.com'}Message: |
| Comment by Robert Stam [ 27/Sep/19 ] |
|
If the decoder for OP_REPLY had thrown an exception when the opcode was not valid it would have been much easier to find a lurking issue with compression against 3.4. |