[CSHARP-4380] Remove legacy shell from test scripts Created: 25/Oct/22  Updated: 07/Dec/23  Resolved: 07/Dec/23

Status: Closed
Project: C# Driver
Component/s: Evergreen Tools
Affects Version/s: None
Fix Version/s: 2.23.0

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Oleksandr Poliakov
Resolution: Fixed Votes: 0
Labels: green-build-friday
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from DRIVERS-2328 Remove legacy shell from test scripts Implementing
Upstream Changes Summary:

DRIVERS-2328:
The legacy shell will no longer be installed in the near future. Drivers are encouraged to remove all usages of the legacy shell in their drivers with this Go driver PR serving as inspiration.

All drivers that require the use of the legacy library are required to define the INSTALL_LEGACY_SHELL environment variable to a non-zero value when running MongoDB installation (either by running run-orchestration.sh or by manually invoking download_and_extract() from download-mongoldb.sh). This variable replaces the current SKIP_LEGACY_SHELL variable which will no longer be respected.

The upcoming changes can be tested by using the development branch for this change. In your evergreen functions, locate the git clone command that clones the drivers-evergreen-tools repository and replace it with this command:

git clone https://github.com/alcaeus/drivers-evergreen-tools.git --depth 1 --branch skip-legacy-shell-by-default $DRIVERS_TOOLS

This will show which of your build tasks still need the legacy shell, which can be installed using the INSTALL_LEGACY_SHELL environment variable in that specific task.

Backwards Compatibility: Fully Compatible
Documentation Changes: Not Needed
Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

This ticket was split from DRIVERS-2328, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 07/Dec/23 ]

Author:

{'name': 'Oleksandr Poliakov', 'email': '31327136+sanych-sun@users.noreply.github.com', 'username': 'sanych-sun'}

Message: CSHARP-4380: Remove legacy shell from test scripts (#1225)
Branch: master
https://github.com/mongodb/mongo-csharp-driver/commit/1bd939d082748bdcea8533ae16d0576442814860

Comment by Githook User [ 28/Nov/23 ]

Author:

{'name': 'Oleksandr Poliakov', 'email': 'oleksandr.poliakov@mongodb.com', 'username': ''}

Message: CSHARP-4380: Remove legacy shell from test scripts
Branch: evergreen-experiments
https://github.com/mongodb/mongo-csharp-driver/commit/b2ba508a90f10c0446f5ffa74f48c9e7c43f7f59

Comment by James Kovacs [ 24/Nov/23 ]

We are still using the legacy shell in our evergreen/evergreen.yml file:

$ grep -E '\bmongo\s' evergreen/*
evergreen/convert-client-cert-to-pkcs12.sh:#   CLIENT_PEM                      Path to mongo -orchestration's client.pem: must be set.
evergreen/evergreen.yml:          mongo aws_e2e_regular_aws.js
evergreen/evergreen.yml:          mongo aws_e2e_assume_role.js
evergreen/evergreen.yml:          mongo aws_e2e_ec2.js
evergreen/evergreen.yml:          mongo --nodb setup.js aws_e2e_ecs.js
evergreen/evergreen.yml:          mongo aws_e2e_web_identity.js

First hit is a false positive, but the remaining 5 are all usages of mongo.

Comment by Dmitry Lukyanov (Inactive) [ 19/Jan/23 ]

The work in this ticket may not require any work for any driver. But if not so, windows testing for the scope of this ticket happens with our driver, so we may have all the solution after ticket will be moved to implementing

Generated at Wed Feb 07 21:48:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.