[CSHARP-560] Remove explicit conversions from BsonValue Created: 08/Sep/12  Updated: 14/May/14  Resolved: 17/Apr/14

Status: Closed
Project: C# Driver
Component/s: BSON
Affects Version/s: 1.8
Fix Version/s: 2.0

Type: Improvement Priority: Major - P3
Reporter: Robert Stam Assignee: Robert Stam
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CSHARP-558 Replace AsXyz and ToXyz in BsonValue ... Closed
related to CSHARP-563 Add indexing to BsonValue Closed
Backwards Compatibility: Minor Change

 Description   

Remove explicit conversions from BsonValue to simplify API. There are already other ways to do the same thing.



 Comments   
Comment by Robert Stam [ 17/Apr/14 ]

We have decided not to do this because it would be a backward compatibility breaking change.

Comment by Robert Stam [ 24/Feb/13 ]

This work was prototyped on the experimental x2.0 branch. This ticket is being reopened for eventual porting to the official 2.0 branch.

Comment by auto [ 11/Sep/12 ]

Author:

{u'date': u'2012-09-10T20:13:51-07:00', u'email': u'robert@10gen.com', u'name': u'rstam'}

Message: CSHARP-560: put the explicit conversions back in their original place in the file to facilitate diffs and restored newer versions from the proper commit (35cbcb2724c10d969192b53c183c620d883ba03).
Branch: x2.0
https://github.com/mongodb/mongo-csharp-driver/commit/75511790e624cf57d7fb4a36525b959243b69800

Comment by auto [ 11/Sep/12 ]

Author:

{u'date': u'2012-09-10T15:25:34-07:00', u'email': u'craiggwilson@gmail.com', u'name': u'Craig Wilson'}

Message: CSHARP-560: added back explicit conversions.
Branch: x2.0
https://github.com/mongodb/mongo-csharp-driver/commit/c594f6e965c53f0c1d885e798d3995afa8b01f6c

Comment by Robert Stam [ 10/Sep/12 ]

Restoring the explicit conversions is related to the linked JIRAs.

Comment by Robert Stam [ 10/Sep/12 ]

We're actually going to reverse ourselves on this decision and put the explicit casts back in. If we ever get rid of the AsXyz properties (still under discussion) the explicit casts will become the official way to convert a BsonValue to some other type.

Comment by Robert Stam [ 09/Sep/12 ]

Pushed to x2.0.

Comment by auto [ 09/Sep/12 ]

Author:

{u'date': u'2012-09-07T19:59:14-07:00', u'email': u'robert@10gen.com', u'name': u'rstam'}

Message: CSHARP-560: remove explicit conversions from BsonValue.
Branch: x2.0
https://github.com/mongodb/mongo-csharp-driver/commit/3edb0030eac312356537e4404ef3e4d2fdb927db

Comment by Robert Stam [ 08/Sep/12 ]

In code review.

Generated at Wed Feb 07 21:37:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.