[CXX-1009] mongocxx::pool should take options::pool, not options::ssl Created: 29/Aug/16  Updated: 29/Nov/16  Resolved: 08/Oct/16

Status: Closed
Project: C++ Driver
Component/s: API
Affects Version/s: None
Fix Version/s: 3.1.0

Type: Bug Priority: Major - P3
Reporter: David Golden Assignee: J Rassi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CDRIVER-1546 What is the expected direction for cl... Closed

 Description   

The pool class needs to proxy all options onto clients returned from the pool, so it needs to take the same options as client does.

Many options come from the URI, but some don't. Currently, options::clients includes options::ssl, but more could be added in the future, such as APM.



 Comments   
Comment by Githook User [ 29/Nov/16 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1009 pool ctor should take options::pool, not options::ssl

This is an API-breaking change to improve the consistency between the
pool class and the client class.

Existing users of the pool class who are passing ssl options to the
pool constructor should instead construct the appropriate
options::pool object.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/ac271fe92aedb23de42768402ab7573188c11dcb

Comment by Githook User [ 29/Nov/16 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1009 Add options::pool
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/2849d7964d7903c34690ee94ae96d7c1680409e9

Comment by Githook User [ 08/Oct/16 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1009 pool ctor should take options::pool, not options::ssl

This is an API-breaking change to improve the consistency between the
pool class and the client class.

Existing users of the pool class who are passing ssl options to the
pool constructor should instead construct the appropriate
options::pool object.
Branch: 3.1-dev
https://github.com/mongodb/mongo-cxx-driver/commit/ac271fe92aedb23de42768402ab7573188c11dcb

Comment by Githook User [ 08/Oct/16 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1009 Add options::pool
Branch: 3.1-dev
https://github.com/mongodb/mongo-cxx-driver/commit/2849d7964d7903c34690ee94ae96d7c1680409e9

Comment by David Golden [ 16/Sep/16 ]

Resolution pending discussion in CDRIVER-1546

Comment by J Rassi [ 15/Sep/16 ]

https://github.com/mongodb/mongo-cxx-driver/pull/533

Generated at Wed Feb 07 22:01:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.