[CXX-1053] Add getters to options::create_collection/options::create_view/validation_criteria classes, make setters support chaining, deprecate to_document() methods Created: 29/Sep/16 Updated: 13/Dec/16 Resolved: 28/Nov/16 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | API |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | J Rassi | Assignee: | J Rassi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||
| Description |
|
The options::create_collection and options::create_view classes vary from the other options classes in that they embed knowledge of the command request formats for their command (the "create" command). We should add getters to these classes, and deprecate their to_document() methods. Once this is done, these classes will be more struct-like and thus more consistent with the other options classes. Knowledge of the command format for "create" could then be moved to the collection class, where it belongs. Similar work should be completed for the validation_criteria class. The setters for the validation_criteria class should also support method chaining, for consistency with similar struct-like classes. The deprecations added in this ticket will be documentation-only deprecations. The work to add compiler warnings for the newly-deprecated methods will be completed under |
| Comments |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: Catch attempts to convert comparison operands to strings with |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: These methods now have a return type of 'validation_criteria&'. They |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: Catch attempts to convert comparison operands to strings with |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: These methods now have a return type of 'validation_criteria&'. They |
| Comment by Githook User [ 28/Nov/16 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by J Rassi [ 18/Nov/16 ] |
|
Marking this ticket as a minor backwards-incompatible change, due to the new deprecations introduced, and the change in the return type for the validation_criteria setters. |
| Comment by David Golden [ 30/Sep/16 ] |
|
I agree. It's also better forward compatibility in case the server changes the command format. |