[CXX-1086] Deprecate non-const methods on mongocxx::client Created: 12/Oct/16 Updated: 12/Jul/17 Resolved: 14/Apr/17 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Documentation |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | David Golden | Assignee: | Samuel Rossi (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
We should deprecate all of the non-const methods on mongocxx::client, namely:
This would allow us to eventually remove the calls to mongoc_client_set_read_concern() and others from client.cpp, which in turn would allow the C++ driver to be in compliance with the C driver requirement of "It is a programming error to call this function on a client from a mongoc_client_pool_t.". We should document that users should instead set these values on the client/pool URI, or the database or collection objects derived from the client instead. Original description:
|
| Comments |
| Comment by Githook User [ 14/Apr/17 ] |
|
Author: {u'username': u'saghm', u'name': u'Saghm Rossi', u'email': u'saghmrossi@gmail.com'}Message: |
| Comment by David Golden [ 14/Apr/17 ] |
|
Agreed. Let's deprecate in the documentation. |
| Comment by J Rassi [ 12/Apr/17 ] |
|
david.golden: I'm pulling this into 3.2.0-rc0, feel free to bump it back out if you'd like. |
| Comment by David Golden [ 14/Oct/16 ] |
|
I'm targeting this for 4.0-required as I think we need time to develop a good solution, but I don't think a solution is optional. |
| Comment by David Golden [ 14/Oct/16 ] |
|
CDRIVER-938 addresses this as well. Their plan seem to be to prohibit modifying options on pooled clients. Perhaps we deprecate the functionality like they do, or perhaps we should move towards making client objects fully immutable. |