[CXX-1169] Minor refactoring (PR #578) Created: 15/Dec/16  Updated: 17/Nov/17  Resolved: 21/Mar/17

Status: Closed
Project: C++ Driver
Component/s: Implementation
Affects Version/s: None
Fix Version/s: 3.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: David Golden Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

This is a tracking ticket for PR #578:

Initially I intended to remove the explicit clearing of the stack in the builder::core _impl destructor, but when I did that the tests had a memory corruption.

I am not sure why this is, possibly a double free maybe? (Maybe the stack needs to be cleared before bson_destroy?)



 Comments   
Comment by Githook User [ 21/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1169 Simplify destruction logic for core::impl

Introduces a lightweight version of mongocxx::libbson::scoped_bson_t
to core.cpp called managed_bson_t, with static linkage.

It would be nice to be able to move scoped_bson_t into bsoncxx and use
it from mongocxx, but we don't have the build infrastructure yet
needed to share private implementation classes between bsoncxx and
mongocxx (without exporting these classes).
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/cc73e184654aff119fd4ab7eb2115fe83b49c0bd

Comment by Githook User [ 21/Mar/17 ]

Author:

{u'username': u'koraa', u'name': u'Karolin Varner', u'email': u'karo@cupdev.net'}

Message: CXX-1169 Prefix the CITER macro with BSONCXX_
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/d642e297f7d1f6adeb395995c8e85951e58d4fe7

Comment by Githook User [ 21/Mar/17 ]

Author:

{u'username': u'koraa', u'name': u'Karolin Varner', u'email': u'karo@cupdev.net'}

Message: CXX-1169 Avoid false positives in the clang static analyzer

The analyzer does not get what the SECTION macro does
and thinks the variables might be uninitialized.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/7bacc731489bd1d3d64166892c759b274d93b519

Generated at Wed Feb 07 22:01:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.