[CXX-1235] PIMPL gridfs bucket, uploader, and downloader classes Created: 01/Mar/17 Updated: 27/Mar/17 Resolved: 24/Mar/17 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Implementation |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Samuel Rossi (Inactive) | Assignee: | J Rassi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
The classes mongocxx::gridfs::bucket, mongocxx::gridfs::uploader, and mongocxx::gridfs::downloader should be PIMPL'd. This will make the header files simpler and make future ABI stability easier to achieve, as well as making the classes more consistent with the rest of our codebase. |
| Comments |
| Comment by Githook User [ 27/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: The implicit conversion failed on one of our clang 3.6 builders that |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: This renames md5.hpp to md5.h, which keeps it from being installed as |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 24/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: De-duplicates includes from hpp and cpp, adds includes for types that |
| Comment by Githook User [ 23/Mar/17 ] |
|
Author: {u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}Message: De-duplicates includes from hpp and cpp, adds includes for types that |
| Comment by Samuel Rossi (Inactive) [ 09/Mar/17 ] |
|
Because mongocxx/gridfs/uploader.hpp needs to include src/mongocxx/third_party/md5.h, md5.h needed to be changed to md5.hpp so it would be installed (since .h files are ignored by cmake during the installation process). As part of this work, mongocxx/src/third_party/md5.hpp should be changed back to md5.h, since only the private header for the implementation of gridfs::uploader will need to include the md5 header. |