[CXX-1235] PIMPL gridfs bucket, uploader, and downloader classes Created: 01/Mar/17  Updated: 27/Mar/17  Resolved: 24/Mar/17

Status: Closed
Project: C++ Driver
Component/s: Implementation
Affects Version/s: None
Fix Version/s: 3.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Samuel Rossi (Inactive) Assignee: J Rassi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CXX-1130 Implement GridFS Spec Closed

 Description   

The classes mongocxx::gridfs::bucket, mongocxx::gridfs::uploader, and mongocxx::gridfs::downloader should be PIMPL'd. This will make the header files simpler and make future ABI stability easier to achieve, as well as making the classes more consistent with the rest of our codebase.



 Comments   
Comment by Githook User [ 27/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 uploader.hh: Make string_view => string conversion explicit

The implicit conversion failed on one of our clang 3.6 builders that
is configured to use MNMLSTC/core as a polyfill. Further work is
needed to determine why the implicit conversion fails, but making the
conversion explicit is an expedient fix for the immediate issue of the
build failure.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/c6c6ca2be6e4f1b9381b11685d7d748b1c1532d3

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Add default ctor and bool conversion op to gridfs::downloader
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/098acd457f64c1ee13aefe0c9f9d4007f44af720

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 gridfs::downloader: hide behind impl class
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/497aec9595aa3b0a470e4bd967605185224ab467

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Add default ctor and bool conversion op to gridfs::uploader
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/aa2e004dbb88022d67c030fe73eef55c0fb3bd02

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Stop installing md5 header from install target

This renames md5.hpp to md5.h, which keeps it from being installed as
part of the "install" target.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/2b4c77b963cbde659daa239da985ded24f1617ed

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 gridfs::uploader: hide behind impl class
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/d55751e5b6820ab489b7338c3791c0b402540ffb

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Add tests for gridfs::bucket default ctor, copy operations
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/0e42396305ad74de5254b81183ff87649bb66ad8

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Add default ctor and bool conversion op to gridfs::bucket
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/9f019a1445d01d93121f7843ad37dc3602209995

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 gridfs::bucket: hide behind impl class
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/e0c6dbd5343a7eeae4300945bd94c6658326fa10

Comment by Githook User [ 24/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Clean up includes in GridFS bucket

De-duplicates includes from hpp and cpp, adds includes for types that
were missing includes.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/e246f887ced9e2267f495f15b3d7cb2d7c406a8d

Comment by Githook User [ 23/Mar/17 ]

Author:

{u'username': u'jrassi', u'name': u'J. Rassi', u'email': u'rassi@10gen.com'}

Message: CXX-1235 Clean up includes in GridFS uploader/downloader

De-duplicates includes from hpp and cpp, adds includes for types that
were missing includes.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/555369016e8cb1ace1b680ce7dd829a7b0dec28b

Comment by Samuel Rossi (Inactive) [ 09/Mar/17 ]

Because mongocxx/gridfs/uploader.hpp needs to include src/mongocxx/third_party/md5.h, md5.h needed to be changed to md5.hpp so it would be installed (since .h files are ignored by cmake during the installation process). As part of this work, mongocxx/src/third_party/md5.hpp should be changed back to md5.h, since only the private header for the implementation of gridfs::uploader will need to include the md5 header.

Generated at Wed Feb 07 22:01:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.