[CXX-1347] Calls to bson_append_* are not checked for errors in the core builder Created: 24/May/17 Updated: 28/Oct/23 Resolved: 20/Jun/17 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | BSON |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Samuel Rossi (Inactive) | Assignee: | Isabella Siu (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Throughout the implementation of the core builder (in src/bsoncxx/builder/core.cpp), there are calls to various `bson_append_*` functions, all of which return a boolean indicating whether the call was successful. We should check the return value of these calls and throw an appropriate error message in the case that that it's false, as currently all of them ignore the value returned/ |
| Comments |
| Comment by Githook User [ 26/Jun/17 ] |
|
Author: {u'username': u'iwysiu', u'name': u'Isabella Siu', u'email': u'sakurablossom@blueblueworld.com'}Message: |