[CXX-1458] Deprecate ~frame() destructor, and add close() function as replacement Created: 25/Oct/17 Updated: 08/Jan/24 Resolved: 17/Nov/17 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Derick Rethans | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Description |
|
For builder/core.cpp, https://github.com/mongodb/mongo-cxx-driver/pull/592/files#diff-5b8d312af0443f26dbfd9206b22cdbf0, As per https://github.com/mongodb/mongo-cxx-driver/pull/592/files#r146877062 |
| Comments |
| Comment by Githook User [ 17/Nov/17 ] |
|
Author: {'name': 'Andrew Morrow', 'username': 'acmorrow', 'email': 'acm@mongodb.com'}Message: |
| Comment by Andrew Morrow (Inactive) [ 04/Nov/17 ] |
|
mira.carey@mongodb.com - We need to figure out what to do here. The current situation isn't good. If the frame destructor is noexcept then we have no way to report errors when failing to write the termination bytes. But if it isn't noexcept, it could throw from the destructor stack of frame}}s. That would also probably be a call to {{terminate. Lets talk about what the right way to fix this might be. |