[CXX-1543] Absorb or render unnecessary patches used by vcpkg to build the driver Created: 04/Apr/18 Updated: 27/Oct/23 Resolved: 30/Aug/23 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Kyle Kloberdanz |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | CXX-2622 |
| Quarter: | FY24Q1 |
| Description |
|
We have been packaged by vcpkg, much like we are for homebrew. This is a very good thing for us as it means that now on both MacOS and Windows the driver can be installed by end users without needing to understand the details of how to build the driver. However, their integration contains several patches that they drop on the code before building. We should research these patches and understand why they are necessary or desirable for vcpkg, and then either take those patches ourselves, or add the necessary build system support to render them unnecessary, so that vcpkg can use the stock code. We should also remember to inform the vcpkg maintainer for mongo-cxx-driver (along with the homebrew one), when we make significant changes to our build or install process, so that they aren't caught off guard. You can see the current list of patch files here: https://github.com/Microsoft/vcpkg/tree/master/ports/mongo-cxx-driver |
| Comments |
| Comment by Kyle Kloberdanz [ 30/Aug/23 ] |
|
Most patches in vcpkg have already been removed. The only remaining patch is to fix a bug that Roberto fixed a couple months ago and will be in the next minor version release. The C++ driver is frequently updated in vcpkg and there are no more patches to absorb. |