[CXX-1689] database::_create_collection is not using C++17-compatible string conversion. Created: 07/Nov/18  Updated: 28/Oct/23  Resolved: 07/Nov/18

Status: Closed
Project: C++ Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 3.5.0, 3.4.1

Type: Bug Priority: Major - P3
Reporter: Piotr Szczepanski Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: internal-woes
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to CXX-1688 MongoDB CXX driver does not compile w... Closed
is related to CXX-1690 Create C++17 variants Closed

 Description   

std::string_view::to_string() is not defined in C++17.



 Comments   
Comment by Kevin Albertson [ 08/Jul/19 ]

Putting this in a patch release goes against our C driver practice of only putting bug fixes to bugs introduced in that same minor release. Though this seems very low risk, so I would not be opposed to putting this into 3.4.1.

FWIW I think based on discussion in #cxx-driver, redbeard0531 would also be interested in having CXX-1707 land soon as well. If that ends up changing target names, I don't think that should go in a patch release.

Comment by Mathias Stearn [ 04/Jul/19 ]

Can we get a new release with this fix? The current latest release doesn't build with -DCMAKE_CXX_STANDARD=17.

Comment by Kevin Albertson [ 07/Nov/18 ]

Thank you for the contribution Piotr! Your pull request has been merged.

Comment by Githook User [ 07/Nov/18 ]

Author:

{'name': 'tamaroth', 'email': 'tamaroth@tamaroth.eu', 'username': 'tamaroth'}

Message: CXX-1689 Fix string_view to string conversion.
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/602d8cc9370a9953177690b1ab47f5c9da5ed569

Comment by Piotr Szczepanski [ 07/Nov/18 ]

I have created a pull request that fixes the issue:
https://github.com/mongodb/mongo-cxx-driver/pull/639

Generated at Wed Feb 07 22:03:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.