[CXX-1689] database::_create_collection is not using C++17-compatible string conversion. Created: 07/Nov/18 Updated: 28/Oct/23 Resolved: 07/Nov/18 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.0, 3.4.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Piotr Szczepanski | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | internal-woes | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
std::string_view::to_string() is not defined in C++17. |
| Comments |
| Comment by Kevin Albertson [ 08/Jul/19 ] |
|
Putting this in a patch release goes against our C driver practice of only putting bug fixes to bugs introduced in that same minor release. Though this seems very low risk, so I would not be opposed to putting this into 3.4.1. FWIW I think based on discussion in #cxx-driver, redbeard0531 would also be interested in having |
| Comment by Mathias Stearn [ 04/Jul/19 ] |
|
Can we get a new release with this fix? The current latest release doesn't build with -DCMAKE_CXX_STANDARD=17. |
| Comment by Kevin Albertson [ 07/Nov/18 ] |
|
Thank you for the contribution Piotr! Your pull request has been merged. |
| Comment by Githook User [ 07/Nov/18 ] |
|
Author: {'name': 'tamaroth', 'email': 'tamaroth@tamaroth.eu', 'username': 'tamaroth'}Message: |
| Comment by Piotr Szczepanski [ 07/Nov/18 ] |
|
I have created a pull request that fixes the issue: |