[CXX-196] 26compat rotatable_file_writer_test does not compile in C++11 mode with libc++ Created: 20/Apr/14  Updated: 05/May/14  Resolved: 22/Apr/14

Status: Closed
Project: C++ Driver
Component/s: None
Affects Version/s: None
Fix Version/s: legacy-0.0-26compat-2.6.1

Type: Bug Priority: Major - P3
Reporter: Kevin Locke Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: c++11, legacy-cxx
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to CXX-155 rotatable_file_writer_test does not c... Closed

 Description   

Commit 9f28c088968e920625cb84b00362d8f7398f486c which was applied the legacy branch to fix CXX-155 hasn't been applied to the 26compat branch. Is there any chance this fix could be applied to this branch as well for those of us using 26compat?

I realize it is in maintenance mode, but since this is the only change required for it to build in C+11 mode and there is negligible risk of breakage, I was hoping it could still be applied. In particular because the 2.5 series drivers built in C+11 and I am working with a codebase which relies on it, so it would smooth the upgrade path for myself and for other users in a similar situation.

Thanks for considering,
Kevin



 Comments   
Comment by Githook User [ 22/Apr/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: CXX-196 CXX-155 Force construction of bool to deal with explicit operator bool on streams

(cherry picked from commit 9f28c088968e920625cb84b00362d8f7398f486c)
Branch: 26compat
https://github.com/mongodb/mongo-cxx-driver/commit/e2ee676799ead4eaab2f7eb6cca96384c92fc2b9

Comment by Andrew Morrow (Inactive) [ 21/Apr/14 ]

https://github.com/mongodb/mongo-cxx-driver/pull/61

Comment by Kevin Locke [ 21/Apr/14 ]

Great, thanks!

Comment by Andrew Morrow (Inactive) [ 21/Apr/14 ]

Agree we should fix this in 26compat. We will make it happen for the upcoming 26compat 2.6.1 release which will follow shortly after server 2.6.1. That release is tentatively scheduled for April 28th.

Generated at Wed Feb 07 21:58:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.