[CXX-204] Solaris build depends on 'timegm' functionality Created: 22/Apr/14  Updated: 04/Sep/14  Resolved: 16/Jun/14

Status: Closed
Project: C++ Driver
Component/s: Portability
Affects Version/s: legacy-0.0-26compat-2.6.0
Fix Version/s: legacy-0.0-26compat-2.6.2, legacy-0.10.0

Type: Bug Priority: Blocker - P1
Reporter: Itay Neeman Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 1
Labels: legacy-cxx
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Non-illumos/SmartOS Solaris



 Description   

'timegm' is not a POSIX-compliant function, and thus fails to compile on some variants of Solaris. See SERVER-13446 for more details.



 Comments   
Comment by Githook User [ 04/Sep/14 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: CXX-204 actually include vendored timegm on solaris
Branch: legacy
https://github.com/mongodb/mongo-cxx-driver/commit/c4b6d92485f777face883a32d382ba0b32405f52

Comment by Githook User [ 16/Jun/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: CXX-204 Add missed timegm implementation files from previous commit
Branch: 26compat
https://github.com/mongodb/mongo-cxx-driver/commit/1c5860f4fe21774afca0f90247b18176a9c09f90

Comment by Githook User [ 30/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: CXX-204 Use vendored timegm implementation if platform does not offer it

(cherry picked from commit 5bf477aa3dee9e82c9c2286a9ad8341cd71dfe97)

Conflicts:
SConstruct
src/mongo/util/time_support.cpp
Branch: 26compat
https://github.com/mongodb/mongo-cxx-driver/commit/6f6bbf0e54b7c146e8d7d76884d3275fe450165f

Comment by Andrew Morrow (Inactive) [ 30/May/14 ]

This is done on legacy, but still needs a backport to 26compat. Note that the upstream fix was handled differently, which is why we did our own commit for this and need to do our own backport (we won't pick this change up from server 2.6.2 backports).

Comment by Githook User [ 30/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: CXX-204 Use vendored timegm implementation if platform does not offer it
Branch: legacy
https://github.com/mongodb/mongo-cxx-driver/commit/5bf477aa3dee9e82c9c2286a9ad8341cd71dfe97

Comment by Andrew Morrow (Inactive) [ 29/May/14 ]

https://github.com/mongodb/mongo-cxx-driver/pull/88

Comment by Andrew Morrow (Inactive) [ 05/May/14 ]

Not yet fixed upstream in server repo so bumping out into subsequent driver releases.

Generated at Wed Feb 07 21:58:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.