[CXX-2258] Prelude headers applied incorrectly Created: 11/May/21  Updated: 28/Oct/23  Resolved: 27/May/21

Status: Closed
Project: C++ Driver
Component/s: Implementation
Affects Version/s: None
Fix Version/s: 3.7.0, 3.6.4, 3.7.0-beta1

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Benji Rewis (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The documentation at https://github.com/mongodb/mongo-cxx-driver/blob/master/CONTRIBUTING.md#headers incorrectly states that the `prelude` header should come before the driver headers. That is mistaken. The order should look like:

#pragma once
 
#include <vector>
 
#include <driver/blah.hpp>
 
#include <driver/config/prelude.hpp>

The codebase should also be audited and aligned with this ordering.



 Comments   
Comment by Benji Rewis (Inactive) [ 27/May/21 ]

Added to releases/v3.6 branch with commit https://github.com/mongodb/mongo-cxx-driver/commit/8a9ce93234f020f250c6dea1434865984c64e2c0

Comment by Benji Rewis (Inactive) [ 25/May/21 ]

Changes to v3.6: https://github.com/mongodb/mongo-cxx-driver/pull/797

Comment by Githook User [ 25/May/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: CXX-2258 Change prelude order and rerun clang-format (#796)

Use server_description_hello_response instead of deprecated version
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/7006baba22cfdcd43a45b7298d3f66ec5f67c25b

Comment by Benji Rewis (Inactive) [ 20/May/21 ]

Changes to master: https://github.com/mongodb/mongo-cxx-driver/pull/796

Generated at Wed Feb 07 22:05:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.