[CXX-2266] Use bsoncxx::string::view_or_value in gridfs::bucket Created: 19/May/21 Updated: 16/Oct/23 |
|
| Status: | Backlog |
| Project: | C++ Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Adrian B | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | CXX-2761 | ||||||||
| Description |
|
mongocxx::bucket::bucket_name() takes a std::string. |
| Comments |
| Comment by Adrian B [ 20/May/21 ] |
|
Hi Kevin, |
| Comment by Kevin Albertson [ 20/May/21 ] |
|
Hi adrian.blandin@sovo-tech.com! Thank you for the report. Since mongocxx::bucket::bucket_name retains a copy of the passed string, I don't think this is strictly necessary. Unnecessary copies could be avoided by a std::move of the passed string. But it seems like a worthwhile improvement to make for consistency in the next major release. |