[CXX-245] Atomics selection macros should be in config.h, not on CPPDEFINES Created: 28/May/14 Updated: 13/Jun/14 Resolved: 30/May/14 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | legacy-0.10.0 |
| Type: | Improvement | Priority: | Blocker - P1 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | legacy-cxx | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
For the server, it is appropriate for the macros that select the AtomicWord/AtomicIntrinsics to be CPPDEFINES, since there is no ABI. However, for the driver, we must make these part of the config.h header so the choice of implementation is fixed at build time, since otherwise the consuming client would need to define, or risk an ODR violation. |
| Comments |
| Comment by Githook User [ 30/May/14 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: |
| Comment by Andrew Morrow (Inactive) [ 28/May/14 ] |