[CXX-2790] Replace inline namespace with using-declarations Created: 10/Nov/23 Updated: 19/Jan/24 Resolved: 04/Jan/24 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.10.0 |
| Type: | Task | Priority: | Unknown |
| Reporter: | Ezra Chung | Assignee: | Ezra Chung |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | CXX ABI | ||||||||
| Quarter: | FY24Q3, FY24Q4 | ||||||||
| Description |
|
Inline namespaces do not permit per-symbol migration from ABI version vX to vY. Inline namespaces cannot be (re)declared inline in one context and non-inline in another context. This means future source-breaking-but-binary-compatible upgrades would require transitioning the entire inline ABI namespace from vX to vY, even if only a small selection of entities may motivate the upgrade. To allow for incremental source-breaking-but-binary-compatible upgrades on a per-symbol basis (e.g. upgrading bsoncxx::foo from bsoncxx::vX::foo to bsoncxx::vY::foo), remove inline from the v_noabi namespace and instead use using-declarations to declare entities in the root library namespaces. Current:
Proposed:
Changing inline namespace v_noabi into namespace v_noabi + using-declarations is a source-and-binary-compatible refactor and should not require an API major version bump. |
| Comments |
| Comment by Githook User [ 19/Jan/24 ] |
|
Author: {'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}Message: |
| Comment by Githook User [ 04/Jan/24 ] |
|
Author: {'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}Message:
|
| Comment by Githook User [ 12/Dec/23 ] |
|
Author: {'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}Message:
|