[CXX-515] refactor common CMake logic from mongocxx and bsoncxx into Common.cmake Created: 09/Feb/15 Updated: 13/Feb/15 Resolved: 13/Feb/15 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Adam Midvidy | Assignee: | Adam Midvidy |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Both files are mostly the same. We should have a Common.cmake file that defines functions used in both projects. |
| Comments |
| Comment by Adam Midvidy [ 13/Feb/15 ] |
|
On further thought, I think this is unnecessary. |
| Comment by Adam Midvidy [ 09/Feb/15 ] |
|
I think we would just fork a copy of the file into both repositories. I wasn't planning on going overboard with the refactor, just moving a couple things into functions to make both projects more maintainable and readable. |
| Comment by Andrew Morrow (Inactive) [ 09/Feb/15 ] |
|
My worry with this is what if we subsequently want to move them to separate repos. Which project 'owns' the common logic? bsoncxx? |