[CXX-553] include inline keyword in inline macros Created: 09/Mar/15  Updated: 24/Apr/15  Resolved: 23/Apr/15

Status: Closed
Project: C++ Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 0.1.0

Type: Task Priority: Major - P3
Reporter: Adam Midvidy Assignee: Adam Midvidy
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: PM-123

 Description   

These warnings are fixed by including the inline keyword in our inline macros, as we had some instances of BSONCXX_INLINE without the inline keyword present.

Was: During skunkworks I compiled the driver with GCC 4.8 and got a number of warnings about not being able to inline some functions marked always_inline.

We should audit these and de-inline them if they truly cannot be inlined.



 Comments   
Comment by Githook User [ 23/Apr/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: CXX-553 include inline keyword in inline macros
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/72dca8d1c841de665ef8094fcf7d6a6d93819a30

Comment by Adam Midvidy [ 22/Apr/15 ]

https://github.com/mongodb/mongo-cxx-driver/pull/280/files

Generated at Wed Feb 07 21:59:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.