[CXX-593] missing bsoncxx::document::view::empty Created: 07/May/15 Updated: 15/May/15 Resolved: 11/May/15 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | API |
| Affects Version/s: | None |
| Fix Version/s: | 0.2.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Yuval Hager | Assignee: | Adam Midvidy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
It would be nice to have a function that checks if the underlying document is empty. Without that, the calling code has to compare the returned length() to 5 which is ugly. I've implemented it, will submit a PR soon |
| Comments |
| Comment by Githook User [ 11/May/15 ] |
|
Author: {u'username': u'yhager', u'name': u'Yuval Hager', u'email': u'yhager@yhager.com'}Message: Closes #285 Signed-off-by: Adam Midvidy <amidvidy@gmail.com> |
| Comment by Yuval Hager [ 08/May/15 ] |
|
Thanks for the update Andrew. The PR is at https://github.com/mongodb/mongo-cxx-driver/pull/285 |
| Comment by Andrew Morrow (Inactive) [ 07/May/15 ] |
|
yhager Agree, that is obviously a missing feature. Looking forward to the PR. So you know, it may be a week or so before we can review and merge it, including your other (much appreciated) pull requests, as there are some other projects taking priority at the moment. We are hoping to roll out an 0.2.0 incorporating your fixes and some other improvements in the middle of May. |