[CXX-607] Backport server 3.0.3..3.0.4 changes Created: 04/Jun/15  Updated: 29/Jul/15  Resolved: 19/Jun/15

Status: Closed
Project: C++ Driver
Component/s: Release
Affects Version/s: None
Fix Version/s: legacy-1.0.4

Type: Task Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: legacy-cxx
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Githook User [ 19/Jun/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: CXX-607 Backport server 3.0.3..3.0.4 changes

Server SHAs cherry-picked (with modifications) into this commit:

42140e7
dd81a3b
c5639bd
9706bfd
Branch: legacy
https://github.com/mongodb/mongo-cxx-driver/commit/9b40900f58fb616d50bade062a181cdd3a7d6a18

Comment by Andrew Morrow (Inactive) [ 19/Jun/15 ]

https://github.com/mongodb/mongo-cxx-driver/pull/294

Comment by Andrew Morrow (Inactive) [ 08/Jun/15 ]

renctan - Thanks for confirming.

Comment by Randolph Tan [ 08/Jun/15 ]

acm Based on the patch diff, it looks like SERVER-9788 was indeed integrated to the driver code.

Comment by Andrew Morrow (Inactive) [ 08/Jun/15 ]

renctan - It looks like SERVER-9788 was fixed in 09d2bf2a43cbf6e7ac10d4dc89934528001d0b69, which git tag --contains suggests was first fixed in server r2.7.3. The server r2.7.3 changes were backported to the legacy driver in CXX-275, in commit 659f5e118f4d5347469f7d12ad0b1c9a43caf04e in the legacy repo (see PR https://github.com/mongodb/mongo-cxx-driver/pull/121/files). Looking at CXX-275, it is actually linked to SERVER-9788, which suggests that we probably did explicitly pull in the SERVER-9788 changes. Could you please review the legacy driver changes and confirm that we did indeed backport SERVER-9788, and that we therefore also need to backport the changes for SERVER-18246?

Comment by Randolph Tan [ 07/Jun/15 ]

acm It depends. SERVER-18246 was a regression caused by SERVER-9788. If it that was not backported to the driver, then this will not affect the driver. If it was backported, then it can cause a null pointer reference in the driver, so it should be backported.

Comment by Randolph Tan [ 07/Jun/15 ]

acm Have to be careful in backporting dd81a3b since it changes the signature of the DBClientConnection constructor and is a breaking change for the driver. In order to keep compatibility with existing user code, we need to selectively pick the changes by ignoring the constructor change and put a comment that 'cp' parameter is ignored.

Generated at Wed Feb 07 21:59:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.