[CXX-751] specified timeouts with chrono Created: 30/Nov/15  Updated: 11/Jan/16  Resolved: 11/Dec/15

Status: Closed
Project: C++ Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.0-rc0

Type: Improvement Priority: Minor - P4
Reporter: Matt Cotter Assignee: Tess Avitabile (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: C++11 Driver MongoDB 3.2

 Description   

See discussion at the end of this pull request.



 Comments   
Comment by Githook User [ 11/Dec/15 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: CXX-751 - Fix dangling view
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/9ae6f4d76c99a25f015f94cd8ac6b5f42d4e76d5

Comment by Githook User [ 11/Dec/15 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: CXX-751 - Specify timeouts with chrono
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/a945fde52bb25a781cea663d7e8e94111a23dbec

Comment by Tess Avitabile (Inactive) [ 09/Dec/15 ]

https://github.com/mongodb/mongo-cxx-driver/pull/391

Comment by Tess Avitabile (Inactive) [ 07/Dec/15 ]

samantha.ritter - Do you have thoughts on this?

Comment by Tess Avitabile (Inactive) [ 02/Dec/15 ]

It looks like max_await_time_ms is included in the options for find, and max_time_ms is included in the options for aggregate, count, distinct, find, find_one_and_delete, find_one_and_replace, and find_one_and_update. In collection::find, max_await_time_ms is passed to the C driver, and in collection::aggregate, max_time_ms is passed to the C driver. The other occurrences of max_time_ms are not used. Should I change all of these to use chrono? For find and aggregate, these will get converted to milliseconds to pass them to the C driver, and the other occurrences are not used.

Generated at Wed Feb 07 22:00:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.