[CXX-88] initializer.h is not included in dbclient.h Created: 26/Jun/13 Updated: 04/May/14 Resolved: 02/Apr/14 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | legacy-0.8.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Shaun Verch | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | cxxmove, legacy-cxx | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Description |
|
initializer.h is not included in dbclient.h which means users of the c++ driver have to include it to use our initializers. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 02/Apr/14 ] |
|
Per schwerin's comments about preferring to keep these headers hidden, I'm marking this as won't fix. We can always revisit later if the loss of the direct access to the initialization functions and the mandatory move to mongo::client::initialize is problematic for consumers. |
| Comment by Andy Schwerin [ 12/Mar/14 ] |
|
I'd prefer to hide it. A handful of users probably use initializer.h, so you'll have some support traffic initially. I'm not sure how to alert driver uses that they should be using client/init.h's method, instead. |
| Comment by Andrew Morrow (Inactive) [ 12/Mar/14 ] |
|
I have a patch for this here: https://github.com/acmorrow/mongo-cxx-driver/commit/0b84e87352d54f45212b147d8d06a61a035cc7c9 However, I wonder if this is still useful given that we now have mongo::client::initialize in client/init.h. The export macros are on the initializer functions, so that would argue for inclusion. schwerin do you have thoughts on whether we want to make the initializer.h header publicly consumable, or hide it behind client/init.h. |