[CXX-882] Incorrect mongoc include path, non-pkgconfig Created: 31/Mar/16  Updated: 19/Sep/16  Resolved: 31/Mar/16

Status: Closed
Project: C++ Driver
Component/s: Build
Affects Version/s: 3.0.1
Fix Version/s: 3.0.2

Type: Improvement Priority: Trivial - P5
Reporter: Allan Bazinet Assignee: Matt Cotter
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The FindLibMongoC cmake helper, in the non-pkgconfig path, uses an uppercase version of the include directory. This won't work properly on a case-sensitive system.

Presently:

set(LIBMONGOC_INCLUDE_DIRS ${LIBMONGOC_DIR}/include/libMONGOC-1.0 CACHE INTERNAL "")

Should be:
set(LIBMONGOC_INCLUDE_DIRS ${LIBMONGOC_DIR}/include/libmongoc-1.0 CACHE INTERNAL "")



 Comments   
Comment by Githook User [ 31/Mar/16 ]

Author:

{u'username': u'bazineta', u'name': u'Allan L. Bazinet', u'email': u'allan.bazinet@gmail.com'}

Message: CXX-882 Correct case of include path in cmake find helper

Use correct lower-case value for the libmongoc-1.0 include directory
path when not using pkgconfig to find the library.

Closes #476

Signed-off-by: Matt Cotter <matt.cotter@mongodb.com>
Branch: master
https://github.com/mongodb/mongo-cxx-driver/commit/19148f984e8736794f8b3e3c542c352026d11194

Comment by Allan Bazinet [ 31/Mar/16 ]

https://github.com/mongodb/mongo-cxx-driver/pull/476

Comment by Andrew Morrow (Inactive) [ 31/Mar/16 ]

alb - Also, if you are interested, we would definitely take the above suggested change as a pull request.

Comment by Andrew Morrow (Inactive) [ 31/Mar/16 ]

alb - Nice catch and thanks again for the extensive testing and bug reports. This feature was developed on OS X, for use primarily on Windows systems lacking pkg-config, so it is unsurprising to me that we missed this. We will get it fixed for the next release.

Generated at Wed Feb 07 22:00:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.