[CXX-882] Incorrect mongoc include path, non-pkgconfig Created: 31/Mar/16 Updated: 19/Sep/16 Resolved: 31/Mar/16 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | Build |
| Affects Version/s: | 3.0.1 |
| Fix Version/s: | 3.0.2 |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Allan Bazinet | Assignee: | Matt Cotter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The FindLibMongoC cmake helper, in the non-pkgconfig path, uses an uppercase version of the include directory. This won't work properly on a case-sensitive system. Presently: set(LIBMONGOC_INCLUDE_DIRS ${LIBMONGOC_DIR}/include/libMONGOC-1.0 CACHE INTERNAL "") Should be: |
| Comments |
| Comment by Githook User [ 31/Mar/16 ] |
|
Author: {u'username': u'bazineta', u'name': u'Allan L. Bazinet', u'email': u'allan.bazinet@gmail.com'}Message: Use correct lower-case value for the libmongoc-1.0 include directory Closes #476 Signed-off-by: Matt Cotter <matt.cotter@mongodb.com> |
| Comment by Allan Bazinet [ 31/Mar/16 ] |
| Comment by Andrew Morrow (Inactive) [ 31/Mar/16 ] |
|
alb - Also, if you are interested, we would definitely take the above suggested change as a pull request. |
| Comment by Andrew Morrow (Inactive) [ 31/Mar/16 ] |
|
alb - Nice catch and thanks again for the extensive testing and bug reports. This feature was developed on OS X, for use primarily on Windows systems lacking pkg-config, so it is unsurprising to me that we missed this. We will get it fixed for the next release. |