[CXX-924] legacy driver fails to build on Hurd Created: 07/Jun/16  Updated: 23/Jun/16  Resolved: 21/Jun/16

Status: Closed
Project: C++ Driver
Component/s: Build, Portability
Affects Version/s: legacy-1.1.1
Fix Version/s: legacy-1.1.2

Type: Bug Priority: Major - P3
Reporter: Giulio Paci Assignee: J Rassi
Resolution: Done Votes: 0
Labels: legacy-cxx
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File 1002_fix_compilation_on_freebsd_and_hurd.patch    
Issue Links:
Depends
is depended on by CXX-921 legacy driver fails to build on FreeBSD Closed

 Description   

The legacy version of the driver is failing to build on Debian with Hurd kernel with the following error:

src/mongo/platform/random.cpp:157:2: error: #error Must implement SecureRandom for platform

As far as I know Debian Hurd has /dev/urandom and it sould be possible to detect it using _gnu_hurd_ macro (not tested yet, as I do not have direct access to an hurd installation at the moment).



 Comments   
Comment by J Rassi [ 23/Jun/16 ]

Thanks again for the pull request, giuliopaci. Your fix has been incorporated in the the release for version legacy-1.1.2 of the C++ driver.

~ rassi

Comment by Githook User [ 21/Jun/16 ]

Author:

{u'username': u'giuliopaci', u'name': u'Giulio Paci', u'email': u'giuliopaci@gmail.com'}

Message: CXX-924 Fix compilation on Debian GNU/Hurd.

Closes #498

Signed-off-by: J. Rassi <rassi@10gen.com>
Branch: legacy
https://github.com/mongodb/mongo-cxx-driver/commit/aa6ed6eca43e6e127495d439cb195c71ecc96011

Comment by J Rassi [ 15/Jun/16 ]

https://github.com/mongodb/mongo-cxx-driver/pull/498

Comment by Giulio Paci [ 15/Jun/16 ]

I signed the agreement and done the pull request.

Comment by J Rassi [ 14/Jun/16 ]

Hi giuliopaci,

We'd like to merge your patch, but first, would you mind opening a pull request on GitHub for your patch, and signing our contributor's agreement? That's our standard workflow for accepting contributions.

Thanks.
~ rassi

Comment by Giulio Paci [ 13/Jun/16 ]

The attached patch file makes compilation succeed on both Debian GNU/FreeBSD and Debian GNU/Hurd.

"scons unit" has also been run successfully.

Generated at Wed Feb 07 22:00:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.