[CXX-984] Improve use of bson_init_static Created: 07/Aug/16 Updated: 17/Nov/17 Resolved: 26/Jun/17 |
|
| Status: | Closed |
| Project: | C++ Driver |
| Component/s: | BSON, Implementation |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Golden | Assignee: | Isabella Siu (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
We call bson_init_static repeatedly and redundantly (e.g. on every element access). Update: we can't cache a bson_t because it uses internal references and it therefore non-copyable without dangling pointers. We've proposed |
| Comments |
| Comment by Githook User [ 26/Jun/17 ] |
|
Author: {u'username': u'iwysiu', u'name': u'Isabella Siu', u'email': u'sakurablossom@blueblueworld.com'}Message: |
| Comment by David Golden [ 22/Feb/17 ] |
|
This is blocked waiting on |
| Comment by David Golden [ 05/Oct/16 ] |
|
I've split this to cover the improvement and linked to the general "check all return values" ticket for the other part. |
| Comment by Andrew Morrow (Inactive) [ 08/Aug/16 ] |
|
I'd argue that it is a bug, which is why I scheduled it for 3.0.2. |