[DOCS-13395] Investigate changes in SERVER-43069: Ops that are slow to apply don't condition on slowOpSampleRate Created: 06/Feb/20  Updated: 13/Nov/23  Resolved: 09/Nov/21

Status: Closed
Project: Documentation
Component/s: manual
Affects Version/s: None
Fix Version/s: 4.3.4, Server_Docs_20231030, Server_Docs_20231106, Server_Docs_20231105, Server_Docs_20231113

Type: Task Priority: Major - P3
Reporter: Backlog - Core Eng Program Management Team Assignee: Jeffrey Allen
Resolution: Fixed Votes: 0
Labels: docs-administration, docs-query
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
documents SERVER-43069 Ops that are slow to apply don't cond... Closed
Participants:
Days since reply: 2 years, 13 weeks, 1 day ago
Epic Link: DOCSP-12974
Story Points: 3

 Description   

Description

Downstream Change Summary

Conditioned logging for slow operations on the sample rate.

Existing behavior prior to this ticket: https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog

Description of Linked Ticket

Here's the code in question: https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/repl/sync_tail.cpp#L335-L351

That should be doing something similar to https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/ops/write_ops_exec.cpp#L122-L124

This behaviour is called out in https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog, though I don't see any discussion on SERVER-32146 or DOCS-12178 for whether sampling was considered.

There's also a couple other places where this might need to be checked:

It's possible a better fix would be to decouple slowOpSampleRate and slowms, such that you log all slow operations but then subject non-slow ops to sampling.

Scope of changes

Impact to Other Docs

MVP (Work and Date)

Resources (Scope or Design Docs, Invision, etc.)



 Comments   
Comment by Githook User [ 09/Nov/21 ]

Author:

{'name': 'Jeff Allen', 'email': 'jeffrey.allen@10gen.com', 'username': 'jeff-allen-mongo'}

Message: (DOCS-13395): slowOpSampleRate affects secondary logs
Branch: v4.4
https://github.com/mongodb/docs/commit/f8d24f56a7b95b03611f2f18d421ae9025bc2989

Comment by Githook User [ 09/Nov/21 ]

Author:

{'name': 'Jeff Allen', 'email': 'jeffrey.allen@10gen.com', 'username': 'jeff-allen-mongo'}

Message: (DOCS-13395): slowOpSampleRate affects secondary logs
Branch: v5.0
https://github.com/mongodb/docs/commit/ba95e8e3d820a8b70d4df87f43d9857740d12f44

Comment by Githook User [ 09/Nov/21 ]

Author:

{'name': 'Jeff Allen', 'email': 'jeffrey.allen@10gen.com', 'username': 'jeff-allen-mongo'}

Message: (DOCS-13395): slowOpSampleRate affects secondary logs
Branch: master
https://github.com/mongodb/docs/commit/459754f697e2ab863e862cb7e857b970ab05f1ca

Generated at Thu Feb 08 08:07:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.