[DOCS-14214] Investigate changes in SERVER-54299: Mark OrMatchExpression::matchesSingleElement as dead code Created: 11/Feb/21 Updated: 13/Nov/23 Resolved: 12/Feb/21 |
|
| Status: | Closed |
| Project: | Documentation |
| Component/s: | manual, Server |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0, Server_Docs_20231030, Server_Docs_20231106, Server_Docs_20231105, Server_Docs_20231113 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Backlog - Core Eng Program Management Team | Assignee: | Unassigned |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Days since reply: | 2 years, 51 weeks, 6 days ago | ||||||||
| Epic Link: | DOCSP-9747 | ||||||||
| Description |
DescriptionDownstream Change Summary We have marked one of the methods related to $or operator as dead code. We are certain that no user query can lead to the execution of this method, so this change should not impact anything. Description of Linked Ticket During the discussion of Our coverage report for July 2019 says that this method is not covered by tests. Recent Evergreen patch where this method was replaced with MONGO_UNREACHABLE passes without any failures. It is highly unlikely that our tests do not cover some case where OrMatchExpression::matchesSingleElement is used, so we concluded that this is a dead code. We should replace the body of this method with MONGO_UNREACHABLE_TASSERT to avoid further confusion. Scope of changesImpact to Other DocsMVP (Work and Date)Resources (Scope or Design Docs, Invision, etc.) |