[DOCS-14886] [SERVER] Investigate changes in SERVER-59970: Fix return value from authenticate command Created: 20/Oct/21 Updated: 03/Nov/21 Resolved: 03/Nov/21 |
|
| Status: | Closed |
| Project: | Documentation |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.4, 5.2.0, 5.1.0-rc2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Backlog - Core Eng Program Management Team | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Days since reply: | 2 years, 14 weeks ago | ||||||||
| Epic Link: | DOCSP-15042 | ||||||||
| Description |
|
Downstream Change Summary As a note for documentation, we may cite that from 5.0.0 through 5.0.3 (inclusive) the Unknown macro: {authenticate}
command incorrectly swaps the values returned via user and dbname. Description of Linked TicketTyped command conversion of the {authenticate: 1} command inadvertently swapped the user and db fields resulting in replies like:
This happens here: https://github.com/mongodb/mongo/blob/d5156d91a608a3b7cf30fbdb63a2d31783389a47/src/mongo/db/commands/authentication_commands.cpp#L367
This initializes the reply through two string args to the constructor which inobviously are passed in the wrong order (DB comes first). We can fix this with a 2-line swap:
But a more durable fix which doesn't reply on a generated constructor signature would be to construct by parts:
This way there's no ambiguity or hard to spot ordering issues. |
| Comments |
| Comment by Ian Fogelman [ 03/Nov/21 ] |
|
This does not have an impact on existing documentation.
|
| Comment by PM Bot [ 20/Oct/21 ] |
|
Downstream changes updated for upstream command incorrectly swaps the values returned via user and dbname. |