[DOCS-16547] [SERVER] Investigate changes in SERVER-83754: FCV feature flag check should handle upgrade/downgrade Created: 13/Dec/23  Updated: 13/Dec/23

Status: Ready for Work
Project: Documentation
Component/s: manual, Server
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Minor - P4
Reporter: Backlog - Core Eng Program Management Team Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: feature
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
documents SERVER-83754 REGISTER_DOCUMENT_SOURCE_WITH_FEATURE... Closed
Participants:
Days since reply: 8 weeks ago

 Description   
Original Downstream Change Summary

We fixed logic in the server and will now be raising the error QueryFeatureNotAllowed in the following scenario. Previously we were raising various different error codes.

The query has a feature recently guarded by a feature flag. Right now in the server this applies to vectorSearch and queryStats. If you downgrade the FCV from an FCV where the feature flag is on by default to an FCV where the feature flag is off by default, a QueryFeatureNotAllowed error will be raised. Previously there were different errors messages for the different features.

Description of Linked Ticket

REGISTER_DOCUMENT_SOURCE_WITH_FEATURE_FLAG checks the value of the feature flag/FCV at startup and registers the document source appropriately. However, if you downgrade the FCV from an FCV where the feature flag is on by default to an FCV where the feature flag is off by default, the document source should error even though the document source will remain registered.

We should consider changing the registration macro to wrap the "parse" function provided with a feature flag check, so that the feature flag is always pessimistically checked if registered with this macro.


Generated at Thu Feb 08 08:15:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.