[DRIVERS-1814] Document errorLabels option for failCommand fail point Created: 21/Jun/21  Updated: 31/Mar/22

Status: Backlog
Project: Drivers
Component/s: Unified Test Runner
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Jeremy Mikola Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-43941 Add "errorLabels" field to failComman... Closed
Driver Changes: Not Needed

 Description   

According to https://github.com/mongodb/mongo/wiki/The-%22failCommand%22-fail-point, the errorLabels option was introduced in 4.3.1 by SERVER-43941 and never backported. The option currently used in one UTF test in poc-retryable-writes.yml but the runOnRequirements permit that test to run on 4.0+ servers. The fact that the test passes suggests that configureFailPoint does not strictly validate data options like arguments for other server commands and may be ignoring unsupported values.

In any event, we should document the option in the UTF spec. The test can likely remain as-is, since errorLabels may only be necessary to ensure the label is added for 4.4+ servers where drivers won't add the label on their own based on an error code.

This came up in mongodb/specifications#1024 for DRIVERS-1483.



 Comments   
Comment by Jeremy Mikola [ 21/Jun/21 ]

Note: while working on this issue, we should also update the docs for appName to note that it was backported to 4.2.9 (SERVER-47195). The UTF spec currently refers to 4.4.0-rc2. Likewise for the blockConnection and blockTimeMS options (SERVER-41070).

Comment by Jeremy Mikola [ 21/Jun/21 ]

The fact that the test passes suggests that configureFailPoint does not strictly validate data options like arguments for other server commands and may be ignoring unsupported values.

lingzhi.deng: Since you worked on SERVER-43941, can you confirm that the server does indeed ignore unrecognized options in the data field for the failCommand fail point (and possibly others)?

Generated at Thu Feb 08 08:24:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.