[DRIVERS-1828] Remove insertedCount from insert result assertions and improve usage of $$unsetOrMatches Created: 01/Jul/21 Updated: 15/Jul/22 Resolved: 15/Jul/22 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | CRUD, Unified Test Runner |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Unknown |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Done | Votes: | 0 |
| Labels: | test-runner, yaml-test | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
|||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | |||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
|||||||||||||||||||||||||||||||||||||||
| Description |
|
Drivers should sync tests in crud/unified and unified-test-format/tests/valid-pass with 44f8310. Spec tests for DRIVERS-1237 inadvertently added insertedCount to insert one/many result assertions, despite that never being a documented field in the CRUD spec. The field was removed in fc21cb7 (associated with DRIVERS-1237) for insertOne operations but that commit neglected to also remove it for insertMany. Since various language tickets have already been closed, this new ticket will be used to track the remaining changes. Additionally, this ticket will address instances where $$unsetOrMatches should have been used in test files (e.g. BulkWriteResult reported through BulkWriteException, entire InsertOneResult and InsertManyResult objects). This was originally done in some test files (e.g. poc-session.yml) in e4808b8 (original commit for DRIVERS-709), but missed in subsequent tests. |
| Comments |
| Comment by Jeremy Mikola [ 02/Jul/21 ] |
|
esha.bhargava / alexander.golin: Please create language tickets for CDRIVER, JAVA, NODE, and PYTHON. I linked up any existing language tickets from DRIVERS-1237 that were not yet resolved. |
| Comment by Githook User [ 02/Jul/21 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: |
| Comment by Jeremy Mikola [ 01/Jul/21 ] |