[DRIVERS-1929] Load Balancer spec test is missing "hello" in failCommand Created: 21/Sep/21  Updated: 30/Nov/23  Resolved: 21/Sep/21

Status: Closed
Project: Drivers
Component/s: Load Balancer
Fix Version/s: None

Type: Task Priority: Unknown
Reporter: Shane Harvey Assignee: Shane Harvey
Resolution: Fixed Votes: 0
Labels: yaml-test
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to DRIVERS-2787 Remove isMaster from failCommands ass... Backlog
Driver Changes: Not Needed

 Description   

There's a Load Balancer spec test that's missing "hello" in failCommand:
https://github.com/mongodb/specifications/blob/8b20d86/source/load-balancers/tests/sdam-error-handling.yml#L156



 Comments   
Comment by Preston Vasquez [ 30/Nov/23 ]

Sounds good, I've created DRIVERS-2787 to follow up

Comment by Shane Harvey [ 30/Nov/23 ]

At the time I resolved this ticket, the load balancer spec did not require hello yet so I don't think this ticket needs to be reopened. The hello change was in DRIVERS-2033 (2022).

It would be good to open a new ticket to remove isMaster from the load balancer tests since drivers should never use it there. What do you think?

Comment by Preston Vasquez [ 30/Nov/23 ]

shane.harvey@mongodb.com The handshake spec test says that

If a server API version is requested or loadBalanced: True, drivers MUST use the hello command for the initial handshake and use the OP_MSG protocol.

In this case, the "errors during the initial connection hello are ignored" test would fail if we only targeted the "isMaster" command. The Go Driver had a bug where the LB was using OP_QUERY and isMaster for the initial handshake, fixing this bug results in this spec test failing. Should this ticket be re-opened for driver changes?

Comment by Shane Harvey [ 21/Sep/21 ]

Closing without driver changes required because this omission doesn't change the behavior of the test. In practice all drivers will be using the legacy hello for this test and if they weren't the test would have been failing.

Comment by Githook User [ 21/Sep/21 ]

Author:

{'name': 'Shane Harvey', 'email': 'shane.harvey@mongodb.com', 'username': 'ShaneHarvey'}

Message: DRIVERS-1929 Add missing "hello" to load balanacer spec test (#1071)
Branch: master
https://github.com/mongodb/specifications/commit/5af2ab77a6e68a4528085504ab6bd1360d30a6c8

Generated at Thu Feb 08 08:24:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.