[DRIVERS-1959] Do not expect both valid:false and warning:true in SRV option URI spec tests Created: 20/Oct/21  Updated: 20/May/22

Status: Implementing
Project: Drivers
Component/s: Initial DNS Seedlist Discovery, URI Options
Fix Version/s: None

Type: Spec Change Priority: Unknown
Reporter: Jeremy Mikola Assignee: Jeremy Mikola
Resolution: Unresolved Votes: 0
Labels: size-small, test-runner
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split to GODRIVER-2196 Do not expect both valid:false and wa... Closed
split to CDRIVER-4196 Do not expect both valid:false and wa... Backlog
split to CXX-2397 Do not expect both valid:false and wa... Backlog
split to NODE-3696 Do not expect both valid:false and wa... Closed
split to CSHARP-3926 Do not expect both valid:false and wa... Closed
split to JAVA-4364 Do not expect both valid:false and wa... Closed
split to MOTOR-840 Do not expect both valid:false and wa... Closed
split to PHPLIB-746 Do not expect both valid:false and wa... Closed
split to PYTHON-2955 Do not expect both valid:false and wa... Closed
split to RUBY-2819 Do not expect both valid:false and wa... Closed
split to RUST-1068 Do not expect both valid:false and wa... Closed
Related
related to PYTHON-2832 Provide options to limit number of mo... Closed
Driver Changes: Needed
Downstream Changes Summary:

Drivers should sync URI options spec tests to mongodb/specifications@84bdb3f.

Driver Compliance:
Key Status/Resolution FixVersion
CDRIVER-4196 Backlog
CXX-2397 Backlog
CSHARP-3926 Fixed 2.14.0
GODRIVER-2196 Done
JAVA-4364 Done
NODE-3696 Done
PHPLIB-746 Won't Fix
PYTHON-2955 Duplicate
MOTOR-840 Duplicate
RUBY-2819 Done 2.18.0
RUST-1068 Duplicate
SWIFT-1382 Duplicate

 Description   

Summary

SRV option URI spec tests introduced in DRIVERS-1519 expect both valid: false and warning: true. In practice, the tests will either raise errors (e.g. using options with non-SRV scheme) or warnings (e.g. invalid value/type), but not both. This was missed during the POCs as neither Java nor Go differentiate errors and warnings raised during URI parsing.

Motivation

Is this ticket only for tests?

Yes.



 Comments   
Comment by Githook User [ 20/Oct/21 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: DRIVERS-1959: Expect either valid:false or warning:true, but not both (#1083)

  • DRIVERS-1959: Expect either valid:false or warning:true, but not both

SRV option tests will either raise errors (e.g. using options with non-SRV scheme) or warnings (e.g. invalid value/type), but not both. This corrects a mistake originally introduced in b508f6d2a1819882d40c4e7e73b95fc8ae3bdfe5.

Comment by Jeremy Mikola [ 20/Oct/21 ]

https://github.com/mongodb/specifications/pull/1083

Generated at Thu Feb 08 08:24:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.