[DRIVERS-2060] Improve integration tests for SRV polling Created: 16/Oct/19 Updated: 31/Mar/22 |
|
| Status: | Backlog |
| Project: | Drivers |
| Component/s: | SRV Polling |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Driver Changes: | Needed | ||||||||
| Description |
|
One of the feedback items from the 4.2 retro was that SRV polling spec tests were incomplete (or lacking) and that the "initial implementation did not have any integration tests, [and] lots of drivers had to make up the tests." I assume this refers to the Test Plan in the spec, which dates back to 49d2c8d (and old commit much earlier in the 4.2 dev cycle). That section also admits that testing is difficult because it involves modifying DNS records. If any drivers were able to implement better integration tests for this feature, we'd do well to contribute those back into the spec so all languages can benefit. |
| Comments |
| Comment by Jeremy Mikola [ 17/Oct/19 ] |
I think that's a good idea. I actually didn't realize there was a tests/ directory for the spec and had only seen the prose tests myself. FWIW, PHP didn't implement these and simply relied on libmongoc's test coverage. I'd propose moving the prose tests into tests/ in a distinct PR with no associated SPEC ticket (since it's not relevant to any driver changes). Then we can consider adding the additional tests you link in SPEC-1407 via this ticket – unless you think the newly acknowledged prose tests will suffice. |
| Comment by Oleg Pudeyev (Inactive) [ 17/Oct/19 ] |
|
There actually are some prose tests in the spec which I may have overlooked because they are specified in the spec document and not in the tests directory. To make it clear that there are tests, is it OK to move their descriptions to tests/README.md? This should be done after https://github.com/mongodb/specifications/pull/663 is merged. I added a list of additional tests implemented in Ruby driver in https://jira.mongodb.org/browse/SPEC-1407?focusedCommentId=2481322&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2481322. |
| Comment by Jeremy Mikola [ 16/Oct/19 ] |
|
oleg.pudeyev: I believe this was your retro feedback. Can you provide some more insight on this? Are there additional tests in Ruby that could be contributed upstream today? |