[DRIVERS-2189] getMore helper should explicitly send inherited comment Created: 03/Feb/22 Updated: 09/Aug/22 Resolved: 09/Aug/22 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | CRUD |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Unknown |
| Reporter: | Dmitry Rybakov | Assignee: | Dmitry Rybakov |
| Resolution: | Done | Votes: | 0 |
| Labels: | size-small, spec-change | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | This ticket changes how getMore command should treat the comment. Drivers should sync unified spec tests find, aggregate, and changeStreams from mongodb/specifications@0fc77cd. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryWhen a cursor was created with comment option set, subsequent getMore command called for this cursor should explicitly send same comment, so that the comment is visible in monitoring events for getMore. If getMore command is send without a comment, it still inherits the comment from the command that created the cursor. The comment will be visible in profiler, logs and $currentOp for that command. However, the comment will not be visible in monitoring events emitted for getMore. Since the main purpose of the comment is to help with debugging/monitoring/detecting problems, it should be visible in monitoring events. Therefore, when a driver send a getMore command on a cursor that was created with a comment, the driver must send the same comment as an option of getMore command. See https://mongodb.slack.com/archives/C0VD105QA/p1643632893344749 for an example. MotivationWho is the affected end user?Any user that wants to use comment for tracing purposes, and who relies on command monitoring for this task. Is this issue urgent?No. It might be easier to implement this together with Is this ticket only for tests?No. |
| Comments |
| Comment by Githook User [ 10/Feb/22 ] |
|
Author: {'name': 'Dmitry Rybakov', 'email': 'dmitry.rybakov@mongodb.com', 'username': 'comandeo'}Message: |