[DRIVERS-219] Change showDiskLoc to showRecordId Created: 09/Apr/15  Updated: 15/Apr/19  Resolved: 21/Jun/16

Status: Closed
Project: Drivers
Component/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Barrie Segal
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on NODE-538 change diskLoc to showRecordId Closed
depends on RUST-21 Change showDiskLoc to showRecordId Closed
depends on CDRIVER-813 Change showDiskLoc to showRecordId Closed
depends on CXX-655 Change showDiskLoc to showRecordId Closed
depends on RUBY-1008 Change showDiskLoc to showRecordId Closed
is depended on by DOCS-5194 Document that cursor.showDiskLoc() is... Closed
Related
is related to SERVER-17718 change showDiskLoc to showRecordId Closed
Driver Compliance:
Key Status/Resolution FixVersion
CDRIVER-813 Done
SCALA-202 Done 1.1.0
RUBY-1008 Done 1.12.4, 2.2.0
CXX-655 Done
NODE-538 Done 2.0.44
RUST-21 Done

 Description   

This ticket is motivated by server changes made under SERVER-17718 and pushed in commit 374438c9134e6e31322.

The aforementioned commit deprecated the shell's showDiskLoc() helper and added a new showRecordId() helper. Drivers which offer a similar helper should consider doing the same.

The $showDiskLoc query flag is still the correct flag for an OP_QUERY style find, so this change shouldn't break drivers. Note, however, that the find command field has been renamed to showRecordId.

Changes made for SERVER-17718 also changed the format of the meta-projection performed by showRecordId from something like

"$diskLoc" : { "file" : 0, "offset" : 20656 }

to something like

"$recordId" : NumberLong(20656)

Drivers tests for this feature may have to be updated.



 Comments   
Comment by Andrew Morrow (Inactive) [ 19/Sep/15 ]

Validating for C++ and C++11: Neither C++ driver has a helper related to showDiskLoc.

IIUC, changes required as part of the find command will be in a separate ticket, not this one. Is that correct?

Comment by Bernie Hackett [ 01/Sep/15 ]

Helpers aren't the issue here. If a user passes $showDiskLoc in the CRUD find() modifiers document do we convert that to showRecordId for the find command, raise an error, or..?

Comment by Jeffrey Yemin [ 27/Aug/15 ]

Java only has a helper for this in the deprecated DBCursor API, which we don't plan on updating.

Comment by Bernie Hackett [ 09/Apr/15 ]

jeff.yemin, craiggwilson, does this affect Java and/or .NET?

Comment by Bernie Hackett [ 09/Apr/15 ]

I'm guessing this only affects drivers that have builders for find()/findOne().

Generated at Thu Feb 08 08:21:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.