[DRIVERS-2196] Sync SDAM tests from mongo server repository Created: 08/Feb/22  Updated: 10/Mar/22  Resolved: 10/Mar/22

Status: Closed
Project: Drivers
Component/s: SDAM
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Neal Beeken Assignee: Shane Harvey
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by DRIVERS-1954 SDAM should give priority to election... Closed
Related
related to SERVER-63399 Update driver SDAM tests Backlog
Driver Changes: Not Needed

 Description   

Summary

The SDAM spec tests in the mongo server repository here:

https://github.com/mongodb/mongo/tree/master/src/mongo/client/sdam/json_tests/sdam_tests

Are out of sync with the drivers SDAM spec tests. The drivers version has changed to using hello over legacy hello, and server has made changes to some properties on test cases.

Motivation

Who is the affected end user?

All drivers running SDAM tests

Who are the stakeholders?

How does this affect the end user?

Are they blocked? Are they annoyed? Are they confused?

How likely is it that this problem or use case will occur?

Main path? Edge case?

If the problem does occur, what are the consequences and how severe are they?

Minor annoyance at a log message? Performance concern? Outage/unavailability? Failover can't complete?

Is this issue urgent?

Yes

Does this ticket have a required timeline? What is it?

Is this ticket required by a downstream team?

Needed by e.g. Atlas, Shell, Compass?

Is this ticket only for tests?

Is this ticket have any functional impact, or is it just test improvements?

It's tests that potentially reveal failures for driver's SDAM implementations



 Comments   
Comment by Shane Harvey [ 10/Mar/22 ]

Closing since there is no work for drivers to do here. The server only made 3 changes to the sdam tests:

  1. https://github.com/mongodb/mongo/commit/0d073ced6c2d652a6543f580390ce3637a280f3c which is tracked by DRIVERS-1322.
  2. https://github.com/mongodb/mongo/commit/a4d9afb865514b69dfd03ae6867fc416f2b7f708 which is a no-op.
  3. https://github.com/mongodb/mongo/commit/565f818c1277998b9712fe2c9fc8c6d6158df07b which was implemented in DRIVERS-1954.
Comment by Shane Harvey [ 08/Feb/22 ]

Note that the server has already implemented DRIVERS-1322 in SERVER-49297. We would need to implement this ticket in DBX to allow server to resync the SDAM tests and vice versa.

Generated at Thu Feb 08 08:24:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.