[DRIVERS-2214] Fix getMore with comment specs Created: 24/Feb/22  Updated: 09/Sep/22  Resolved: 09/Sep/22

Status: Closed
Project: Drivers
Component/s: Change Streams, CRUD
Fix Version/s: None

Type: Bug Priority: Unknown
Reporter: Dmitry Rybakov Assignee: Dmitry Rybakov
Resolution: Done Votes: 0
Labels: yaml-test
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split to CSHARP-4078 Fix getMore with comment specs Closed
split to CXX-2457 Fix getMore with comment specs Closed
split to GODRIVER-2321 Fix getMore with comment specs Closed
split to MOTOR-901 Fix getMore with comment specs Closed
split to PYTHON-3144 Fix getMore with comment specs Closed
split to RUBY-2912 Fix getMore with comment specs Closed
split to RUST-1196 Fix getMore with comment specs Closed
split to PHPLIB-749 Support comment option on command hel... Closed
split to CDRIVER-4199 Add support for the comment field to ... Closed
split to JAVA-4507 Fix getMore with comment specs Closed
split to NODE-4035 Fix getMore with comment specs Closed
Related
is related to DRIVERS-2243 Inherited comment causes OperationFai... Closed
is related to DRIVERS-2244 Test getMore with comment on all topo... Closed
Driver Changes: Needed
Downstream Changes Summary:

Drivers should sync change-streams, aggregate, and find-comment spec tests from mongodb/specifications@ad1ee9b.

Driver Compliance:
Key Status/Resolution FixVersion
CXX-2457 Fixed 3.7.0
CSHARP-4078 Done 2.15.0
GODRIVER-2321 Duplicate
JAVA-4507 Fixed 4.6.0
NODE-4035 Fixed 4.5.0
MOTOR-901 Duplicate
PYTHON-3144 Duplicate
RUBY-2912 Fixed 2.18.0
RUST-1196 Duplicate
SWIFT-1504 Duplicate
PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0
CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0

 Description   

Summary

DRIVERS-2189 added specs for getMore command with a comment. There are two problems with those tests:

1. minServerVersion should be 4.4 since this is the minimal version that supports comment on getMore (see docs).
2. Those tests should not be run against a sharded cluster. On sharded cluster we can get empty GetMore commands (see spec).

Is this issue urgent?

No. It might be easier to implement this together with DRIVERS-742, but this is not required.

Is this ticket only for tests?

Yes.



 Comments   
Comment by Githook User [ 23/Mar/22 ]

Author:

{'name': 'Ross Lawley', 'email': 'ross.lawley@gmail.com', 'username': 'rozza'}

Message: Ensure getMore comments only sent if server >= 4.4.0 (#899)

JAVA-4507
DRIVERS-2214
DRIVERS-2243
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/d25db9cc56062601477d264a1710925b956a95a5

Comment by Githook User [ 24/Feb/22 ]

Author:

{'name': 'Dmitry Rybakov', 'email': 'dmitry.rybakov@mongodb.com', 'username': 'comandeo'}

Message: DRIVERS-2214 Fix getMore with comment specs (#1151)
Branch: master
https://github.com/mongodb/specifications/commit/ad1ee9b764f7d9ff193fe485d31feca536e6a2d7

Generated at Thu Feb 08 08:25:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.