[DRIVERS-2294] Add createCollection and collMod spec tests for changeStreamPreAndPostImages option Created: 26/Apr/22 Updated: 25/Sep/23 Resolved: 25/Sep/23 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | Collection Management |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Benji Rewis (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | yaml-test | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Drivers should sync their collection management spec tests to this commit. Drivers with createCollection and modifyCollection helpers should add a changeStreamPreAndPostImages option that is a document passed in the create or collMod command respectively. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryDownstream changes for benji.rewis@mongodb.com pointed out that we do have a directory for collection management tests (despite not currently having a collection management spec). We should add unified tests for the changeStreamPreAndPostImages option there. Drivers without helpers can skip them as needed. Existing spec tests reference a createCollection database operation. These would be the first tests for a collMod helper, so I'll propose we name that database operation modifyCollection unless anyone objects. Additionally, the server team intentionally implemented changeStreamPreAndPostImages as a document (e.g. {enabled: <boolean>}), so I propose drivers do the same instead of simplifying it as a boolean type and possibly locking themselves into an API limitation down the line. MotivationIs this issue urgent?No, but it should be done alongside language tickets for Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes. |
| Comments |
| Comment by Githook User [ 16/May/22 ] |
|
Author: {'name': 'Jeff Yemin', 'email': 'jeff.yemin@mongodb.com', 'username': 'jyemin'}Message: Add serverless: forbid for collection management tests (#1216)
|
| Comment by Githook User [ 05/May/22 ] |
|
Author: {'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}Message: |
| Comment by Benji Rewis (Inactive) [ 03/May/22 ] |
|
Spec PR: https://github.com/mongodb/specifications/pull/1206 |