[DRIVERS-2322] Restrict change streams unified tests to replicasets Created: 10/May/22 Updated: 31/May/22 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Change Streams |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Benji Rewis (Inactive) | Assignee: | Benji Rewis (Inactive) |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | yaml-test | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Drivers should sync their unified/change-streams.[yml/json] tests to this commit. We've restricted all tests in that file to only run against replicasets for now (many of them already have this restriction) until we have time to look into sharded cluster failures with DRIVERS-2323. If any drivers are not seeing sharded cluster failures, this restriction and spec test update is optional. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryA number of the change streams spec tests in change-streams.yml already only run against replicasets (standalones do not support change streams). Running against regular sharded clusters and sharded replica sets causes unexpected behavior in the command monitoring events observed (usually unexpected drops and writes that cause test failures). The cause of these unexpected events is not immediately clear, so we should restrict the tests in that file to only run against replicasets for the time being. We can re-enable testing against sharded clusters as part of DRIVERS-2323. MotivationWho is the affected end user?Driver devs. How does this affect the end user?A couple teams (at least Go and PHP) are blocked on merging change streams tests because of failures against sharded clusters that likely do not represent bugs in the drivers. How likely is it that this problem or use case will occur?Consistent failures against sharded clusters. If the problem does occur, what are the consequences and how severe are they?This is blocking at least a couple tickets in the Go driver. Is this issue urgent?Somewhat. Is this ticket required by a downstream team?No. Is this ticket only for tests? Yes. |
| Comments |
| Comment by Benji Rewis (Inactive) [ 31/May/22 ] |
|
steve.silvester@mongodb.com made a comment in the downstream changes summary to allow drivers to skip this test sync if they are not seeing sharded cluster failures. Interesting that Python has none; that may be a clue to the eventual resolution of DRIVERS-2323. |
| Comment by Steve Silvester [ 24/May/22 ] |
|
We're running the tests with sharded replica sets against server versions 3.6+ in https://github.com/mongodb/mongo-python-driver/pull/950, so we are not planning to implement this ticket in Python. Perhaps this ticket should be modified to suggest restricting the tests only if there are actual test failures? |
| Comment by Githook User [ 17/May/22 ] |
|
Author: {'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}Message: DRIVERS-2322 Restrict most unified change streams tests to only run against replicasets (#1210) Co-authored-by: Jeremy Mikola <jmikola@gmail.com> |
| Comment by Benji Rewis (Inactive) [ 16/May/22 ] |