[DRIVERS-2329] Require monitors to signal that the topology changed after every check Created: 16/May/22 Updated: 27/Jun/22 Resolved: 27/Jun/22 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | SDAM |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Unknown |
| Reporter: | Patrick Freed | Assignee: | Neal Beeken |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Driver Changes: | Not Needed |
| Description |
| Comments |
| Comment by Githook User [ 27/Jun/22 ] |
|
Author: {'name': 'Neal Beeken', 'email': 'neal.beeken@mongodb.com', 'username': 'nbbeeken'}Message: |
| Comment by Shane Harvey [ 19/May/22 ] |
|
Is this essentially the same issue as |
| Comment by Patrick Freed [ 17/May/22 ] |
|
Yeah, in that case there wouldn't be any need--I mostly had the polling protocol in mind with this ticket. That said, notifying the topology has changed when it actually hasn't should be low-cost, whereas not waking up sleeping operations for longer than necessary can be high cost, so maybe its worth the simplification. This ticket does still affect the streaming protocol, though only checks that create new monitoring connections, since those only happen every heartbeatFrequencyMS unless another check is requested. |
| Comment by Jeffrey Yemin [ 17/May/22 ] |
|
patrick.freed@mongodb.com, what if the check succeeds but the topology version is stale? Currently the spec says that these sort of responses should be discarded without notifying. |