[DRIVERS-2367] Allow RewrapManyDataKeyResult.bulkWriteResult to be optional Created: 23/Jun/22 Updated: 07/Apr/23 Resolved: 07/Apr/23 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | Client Side Encryption |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Ezra Chung | Assignee: | Ezra Chung |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Key Management API | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Quarter: | FY23Q2 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryChange the specification of RewrapManyDataKeyResult.bulkWriteResult from BulkWriteResult to Optional<BulkWriteResult>. Update corresponding unified test files to avoid unnecessarily matching bulkWriteResult against an empty document. MotivationWho is the affected end user?Drivers implementing ClientEncryption.rewrapManyDataKey() and testing against the corresponding unified spec tests. How does this affect the end user?The Client Side Encryption spec currently defines the RewrapManyDataKeyResult.bulkWriteResult field as a BulkWriteResult. This is causing some confusion regarding what the value of bulkWriteResult should be provided ClientEncryption.rewrapManyDataKey() does not issue an unnecessary bulk write command due to no matching key documents to rewrap. How likely is it that this problem or use case will occur?Users that have already implemented ClientEncryption.rewrapManyDataKey() and RewrapManyDataKeyResult may have to update their implementations to allow for the bulkWriteResult field to be optional. If the problem does occur, what are the consequences and how severe are they?If this change is not applied, Drivers may end up with discrepancies in interpretation and implementation of the behavior of rewrapManyDataKey() given the case where there are no matching key documents, thus no well-defined value for bulkWriteResult (an empty document may not be consistent or appropriate across all Drivers). Is this issue urgent?No. Is this ticket required by a downstream team?No. Is this ticket only for tests?No. This may require changes to the implementation of RewrapManyDataKeyResult and corresponding operations that depend on it. |
| Comments |
| Comment by Githook User [ 23/Jun/22 ] |
|
Author: {'name': 'Ezra Chung', 'email': '88335979+eramongodb@users.noreply.github.com', 'username': 'eramongodb'}Message: |