[DRIVERS-2479] Require squash-merging for specifications PRs Created: 25/Oct/22  Updated: 27/Oct/23  Resolved: 27/Oct/22

Status: Closed
Project: Drivers
Component/s: GitHub
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Jeremy Mikola Assignee: Unassigned
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2022-10-25 at 11.46.34 AM.png    
Issue Links:
Related
Driver Changes: Not Needed

 Description   

Summary

This came up in a comment on the scope doc (WRITING-12027) for automated spec testing (DRIVERS-1304). Since that project may trigger on commits in the specifications repository, it may be helpful to require PRs to use squash-merging. Some other drivers (e.g. PHP, Ruby) already require this of PRs and prohibit merge commits and rebases via GitHub's UI.

In rare cases where a PR is intentionally organized into separate commits (sometimes the case with small fixes for multiple DRIVERS tickets), authors can fall back to manually rebasing and merging via the command line (likely a fast-forward w/o a merge commit). If that's agreeable, we can note this in a CONTRIBUTING document.

Motivation

Is this issue urgent?

No, although it may be helpful to address this before or alongside DRIVERS-1304.

Is this ticket required by a downstream team?

No.

Is this ticket only for tests?

No.



 Comments   
Comment by Tom Selander [ 25/Oct/22 ]

jmikola@mongodb.com See Kevin's comment. This looks to be all set, please let us know if any issues.

Generated at Thu Feb 08 08:25:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.